Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44621 )
Change subject: allow 0x34 as ICCRIBA for CHIPSET_C620_SERIES_LEWISBURG
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/flashrom/+/44621/2/ich_descriptors.c
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/44621/2/ich_descriptors.c@a943
PS2, Line 943: return CHIPSET_300_SERIES_CANNON_POINT;
Unfortunately I have not found any documentation related to ICCRIBA.
It used to give some offset, but newer SPI guides just list it as reserved
or reserved with a specific value.
I wonder if any PCH of CHIPSET_300_SERIES_CANNON_POINT has ICCRIBA as 0x34.
I guess all of them. The SPI guides say "Reserved. Set this field to 34h.".
It seems the original C620 models and Sunrise Point PCHs had the same issue,
hence the check for `NM` above. Maybe that's all we need on this path
too?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/44621
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I363aaccfb90e0a127c0f0bb0072e9e85c210b669
Gerrit-Change-Number: 44621
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: David Hendricks
dhendrix.sync@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 21 Aug 2020 19:53:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment