Márton Miklós has posted comments on this change. ( https://review.coreboot.org/25683 )
Change subject: Add support for National Instruments USB-845x devices ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/25683/2/Makefile File Makefile:
https://review.coreboot.org/#/c/25683/2/Makefile@948 PS2, Line 948: LIBS += -lni845x
How is it licensed? If it's not GPLv2 compatible, should we print a […]
I have not find an explicit license for the NI 845x, but a txt file in the installation folder links to the NI's general software license: "This product is licensed to you by National Instruments pursuant to the applicable National Instruments software license agreement."
This can be found here: https://www.ni.com/pdf/legal/us/software_license_agreement.pdf
I have not found any restrictions about the linking external software to their libraries.
https://review.coreboot.org/#/c/25683/2/ni845x_spi.c File ni845x_spi.c:
PS2:
Maybe run this file through `indent` first. And no camel-case, please.
Camel cases removed, do you have an example of what parameters should I use with indent?
https://review.coreboot.org/#/c/25683/2/ni845x_spi.c@47 PS2, Line 47: uInt32
please use stdint. […]
The NI USB-854x API brings these types and I thought that using them for the library calls only would be a good idea because this way we do not need to trust that NI won't change their types definition in the future (which is unlikely).