Hemanth Guruva Reddy has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34234 )
Change subject: flashchips: Add Macronix MX25L51245G as known chip ......................................................................
Patch Set 3:
(4 comments)
Hi Nico,
Thanks for a quick point out, Didn't realize that from flashrom perspective MX66L51235F == MX25L51245G. Despite the MX25L51245G brings in extended command set for Double-Transfer Read commands. adapted the .name of MX66L51235F as the only change needed.
https://review.coreboot.org/c/flashrom/+/34234/2/flashchips.h File flashchips.h:
https://review.coreboot.org/c/flashrom/+/34234/2/flashchips.h@482 PS2, Line 482: #define MACRONIX_MX25L51245G 0x201A
Sigh, now I discovered another issue, the same ID is used by MX66L51235F below. […]
Done
Thanks for a quick point out, Didn't realize that from flashrom perspective MX66L51235F == MX25L51245G. Despite the MX25L51245G brings in extended command set for Double-Transfer Read commands
https://review.coreboot.org/c/flashrom/+/34234/2/flashchips.c File flashchips.c:
https://review.coreboot.org/c/flashrom/+/34234/2/flashchips.c@7789 PS2, Line 7789: .tested = TEST_OK_PREW,
What was tested should be mentioned in the commit message.
Done
This is not necessary anymore
https://review.coreboot.org/c/flashrom/+/34234/2/flashchips.c@7796 PS2, Line 7796: .block_erase = spi_block_erase_20,
There should also be native 4-byte address (4BA) functions: 21/5c/dc. […]
Done
This is not necessary anymore
https://review.coreboot.org/c/flashrom/+/34234/2/flashchips.c@7815 PS2, Line 7815: /* 2.35-3.6V for MX25L51245G */
The datasheet says 2.7V, and why is this a comment if the whole entry is for […]
Done
This is not necessary anymore