Attention is currently required from: Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64029 )
Change subject: meson: relocate config_print_wiki & config_default_programmer_*
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File meson.build:
https://review.coreboot.org/c/flashrom/+/64029/comment/bc67186a_650ac4d8
PS2, Line 417: cargs += '-DCONFIG_DEFAULT_PROGRAMMER_ARGS="' + config_default_programmer_args + '"'
Shouldn't this line be under if condition too? There is no need for default programmer args if default programmer itself is not defined.
But I am happy with this patch only moving block of code without modifications.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/64029
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9538b0aee31b294844d4f4ca0396334a81dfb498
Gerrit-Change-Number: 64029
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Comment-Date: Sun, 08 May 2022 23:40:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment