Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47657 )
Change subject: it85spi.c: Changing the order of functions ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/flashrom/+/47657/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/47657/1//COMMIT_MSG@7 PS1, Line 7: Changing the order of functions Reorder functions with primitives at the top
https://review.coreboot.org/c/flashrom/+/47657/1//COMMIT_MSG@9 PS1, Line 9: This only changes the order of functions in the file, not what : they are doing. With this order, prototype for it85xx_spi_send_command : is not needed. : Moreover the change cleans-up a way for a later work to : refactor singleton states into reentrant pattern. Reshuffle file with no semantic changes, this avoids unnecessary prototypes for static member functions as to pave the way for further cleanups as well as an easier to parse implementation.