13 Apr
2022
13 Apr
'22
5:25 p.m.
Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Tom Hughes. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63001 )
Change subject: programmer: Use C linkage when compiling with C++ ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
flashrom is entirely written in C and should only be compiled with a proper C compiler. […]
I agree with this sentiment. However, for every change there's a reason, we should hear it first. Looking downstream, there's a Chrome EC driver that wants to make use of some C++ API it seems. Any plan to upstream that?
--
To view, visit https://review.coreboot.org/c/flashrom/+/63001
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7e12ead58dee07313d756f1afcc687ba12b6392b
Gerrit-Change-Number: 63001
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Hughes tomhughes@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nikolai Artemiev nartemiev@google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Tom Hughes tomhughes@chromium.org
Gerrit-Comment-Date: Wed, 13 Apr 2022 17:25:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen src@posteo.de
Gerrit-MessageType: comment