4 Nov
2022
4 Nov
'22
8:40 p.m.
Attention is currently required from: Nikolai Artemiev.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69130 )
Change subject: tests: ensure chip erase operation is executed ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File include/flash.h:
https://review.coreboot.org/c/flashrom/+/69130/comment/6a0752d0_d672b9b3 PS1, Line 159: #define UNERASED_VALUE(flash)
https://chromium.googlesource.com/chromiumos/third_party/flashrom/+/refs/hea.... […]
UNERASED_VALUE could also be 0x55. If any chip ever erases to 0x55, whoever manufactured it deserves to be slapped 😄
--
To view, visit https://review.coreboot.org/c/flashrom/+/69130
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia00444dcd2ad96c64832a13201efbd064cd7302d
Gerrit-Change-Number: 69130
Gerrit-PatchSet: 3
Gerrit-Owner: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nikolai Artemiev nartemiev@google.com
Gerrit-Comment-Date: Fri, 04 Nov 2022 20:40:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Comment-In-Reply-To: Nikolai Artemiev nartemiev@google.com
Gerrit-MessageType: comment