22 Sep
2021
22 Sep
'21
8:43 p.m.
Attention is currently required from: Felix Singer, Angel Pons. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57809 )
Change subject: ft2232_spi: prevent use of reserved pins on some programmers ......................................................................
Patch Set 3:
(1 comment)
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/57809/comment/914c94d3_a6c89f90 PS2, Line 417: /* Flyswatter and Flyswatter-2 require GPIO bits 0x80 : * and 0x40 to be driven low to enable output buffers */ : pindir = 0xcb; :
oops, I missed this one
Done
--
To view, visit https://review.coreboot.org/c/flashrom/+/57809
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ied450fa5ef358153adefec3beabc63a62c9f60cd
Gerrit-Change-Number: 57809
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 22 Sep 2021 20:43:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner foss@mniewoehner.de
Gerrit-MessageType: comment