Attention is currently required from: Shiyu Sun, Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49785 )
Change subject: realtek_mst_i2c_spi.c: Move gpio 88 toggle outside write function
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/49785/comment/019aa887_d54459de
PS1, Line 9: used as write protection disable/enable
is it always used to toggle write-protect, or is it board-specific?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/49785
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I237bf9f8aa0fcbb904e7f0c09c74fd179e8c70c1
Gerrit-Change-Number: 49785
Gerrit-PatchSet: 1
Gerrit-Owner: Shiyu Sun
sshiyu@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Shiyu Sun
sshiyu@google.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Thu, 21 Jan 2021 09:08:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment