[flashrom-gerrit] [S] Change in flashrom[1.2.x]: chipset_enable.c: Validate physmap() return rcrb value

[Nico Huber (Code Review)]

Attention is currently required from: Sam McNally, Edward O'Callaghan, Angel Pons.

Hello Sam McNally, build bot (Jenkins), Edward O'Callaghan, Angel Pons,

I'd like you to do a code review.
Please visit

https://review.coreboot.org/c/flashrom/+/67868

to review the following change.

Change subject: chipset_enable.c: Validate physmap() return rcrb value
......................................................................

chipset_enable.c: Validate physmap() return rcrb value

Validate the physical mapping in enable_flash_silvermont().

Change-Id: Icc5a799a06b3f310d9a191fa5eb99b255b20d79d
Signed-off-by: Edward O'Callaghan 
Reviewed-on: https://review.coreboot.org/c/flashrom/+/48225
Tested-by: build bot (Jenkins) 
Reviewed-by: Sam McNally 
Reviewed-by: Angel Pons 
---
M chipset_enable.c
1 file changed, 18 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/68/67868/1

diff --git a/chipset_enable.c b/chipset_enable.c
index 5195b95..bbd0465 100644
--- a/chipset_enable.c
+++ b/chipset_enable.c
@@ -988,6 +988,8 @@

/* Handle GCS (in RCRB) */
    void *rcrb = physmap("BYT RCRB", rcba, 4);
+	if (rcrb == ERROR_PTR)
+		return ERROR_FATAL;
    const enum chipbustype boot_buses = enable_flash_ich_report_gcs(dev, ich_generation, rcrb);
    physunmap(rcrb, 4);