Attention is currently required from: Peter Marheine. Hello build bot (Jenkins), Edward O'Callaghan, Daniel Campello, Anastasia Klimchuk,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/54147
to look at the new patch set (#3).
Change subject: libflashrom: clear layout on flashrom_layout_release ......................................................................
libflashrom: clear layout on flashrom_layout_release
This changes the behavior of flashrom_layout_release to always clear the provided layout, even if it is the global layout (as is currently always the case unless using layout from IFD).
Not clearing it causes confusing behavior where a user may release a layout and create a new one, but if that was the global layout which wasn't cleared there will be stale information in the "new" layout. This can easily lead to writing unexpected flash regions because the API provides no way to stop including regions, and makes it effectively impossible to stop including a region without completely tearing down the library.
Change-Id: I8ba4b356f2a40ccbfd4e91f81af01d5f6a6de515 Signed-off-by: Peter Marheine pmarheine@chromium.org --- M cli_classic.c M flash.h M layout.c 3 files changed, 8 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/47/54147/3