Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44621 )
Change subject: allow 0x34 as ICCRIBA for CHIPSET_C620_SERIES_LEWISBURG ......................................................................
Patch Set 2:
(1 comment)
I guess Intel updated the chipset without changing the marketing name (C620 series). You should check the whole ich_descriptors code if it applies correctly to your descriptor. If it does, CHIPSET_C620_SERIES_LEWISBURG is the right choice, but if it doesn't, we should add a new name. In any case, the detection needs to distinct more accurately between your chipset and 300 series.
https://review.coreboot.org/c/flashrom/+/44621/2/ich_descriptors.c File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/44621/2/ich_descriptors.c@a943 PS2, Line 943: return CHIPSET_300_SERIES_CANNON_POINT; The default path for 0x34 (without warning) leads here. If you change that, 300-series detection will be broken.