24 Nov
2020
24 Nov
'20
2:05 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47874 )
Change subject: lspcon_i2c_spi.c: Fix style ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
What? No! Don't abandon this change, please!
Please no more unnecessary C89'ism. Just use C99 already.
Did you check the change I linked to earlier? Old GCC versions don't like these kinds of initializers, and it caused problems at some point. And even if that is no longer an issue, the other three loops in this file as well as nearly every other file in flashrom use the C89 style.
--
To view, visit https://review.coreboot.org/c/flashrom/+/47874
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4068ae7bdf6e053606cb063f7781dbb2d77792ff
Gerrit-Change-Number: 47874
Gerrit-PatchSet: 1
Gerrit-Owner: Shiyu Sun sshiyu@google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 24 Nov 2020 12:05:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment