Attention is currently required from: Subrata Banik, Edward O'Callaghan, Angel Pons.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69195 )
Change subject: ichspi.c: Read chip ID and use it to populate `flash->chip` ......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/69195/comment/efdfffc3_1b666e60 PS3, Line 21: FIX: w,E
downstream also has https://chromium.googlesource. […]
This was due to write/erase trying to overwrite the ME/flash descriptor regions: ``` FREG0: Flash Descriptor region (0x00000000-0x00000fff) is read-only. FREG1: BIOS region (0x00381000-0x00ffffff) is read-write. FREG2: Management Engine region (0x00001000-0x00380fff) is read-only. ```
Write and erase work if just the writable BIOS region is used: ``` # cat test_layout 0x00381000:0x00ffffff bios
# flashrom -{w,E} --layout test_layout -i bios ```
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/69195/comment/22c63bbf_abda23bc PS2, Line 1486: flash->chip->tested = entry->tested;
Well as long as CB:69842 isn't re-introduced.
Some chip entries may need to be updated with WP test status but this shouldn't cause universal warnings for opaque programmers as in CB:69842.