14 Nov
2019
14 Nov
'19
9:26 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/36426 )
Change subject: sb600spi.c: Generalise determin_generation() after Yangtze ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Is there a public datasheet one could read to check this?
https://review.coreboot.org/c/flashrom/+/36426/3/sb600spi.c File sb600spi.c:
https://review.coreboot.org/c/flashrom/+/36426/3/sb600spi.c@155 PS3, Line 155: Drop these empty lines as well?
--
To view, visit https://review.coreboot.org/c/flashrom/+/36426
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5aa7370025f5c1af56c6cb96194b6f3007d0ede7
Gerrit-Change-Number: 36426
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 14 Nov 2019 21:26:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment