Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44197 )
Change subject: meson.build: Use 'std=gnu17'
......................................................................
Patch Set 4:
Patch Set 1: Code-Review-1
AFAIUI, GCC by default uses *gnu17* according to the documentation: https://gcc.gnu.org/onlinedocs/gcc/Standards.html
The default, if no C language dialect options are given, is -std=gnu17.
Plus, not everyone is using the latest GCC to compile flashrom.
Why not just remove the specified C standard? The official build system (Makefile) does not seem to set it.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/44197
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id47c840c2ef24e57917ccd74e86418e700e6e409
Gerrit-Change-Number: 44197
Gerrit-PatchSet: 4
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 08 Aug 2020 20:29:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment