Attention is currently required from: Nico Huber, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55741 )
Change subject: tests: Guard sys/io.h the same as in hwaccess_x86_io.h ......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/55741/comment/72a10f5d_65549313 PS2, Line 19: BUG=b:181803212
I'd like to know what the bug is?
This "bug" is not really a bug, more like a task, and it just says "Unit tests for Flashrom". I need to add this every time so that my work can be tracked. It feels a bit awkward for me, because I know you can't open b:181803212 and it's just some magic number :\ I have only two magic numbers, this one and 185191942 for register_master API. Everything that is relevant I always discuss in gerrit, so that everyone can see.
Patchset:
PS5:
It seems this is trying to fix problems that don't exist yet? Neither […]
I really like your idea in CB:51487 not to use sys/io.h at all, and instead add few more lines that we need. I am happy to do this instead of this patch. Why sys/io.h is here in the first place: I was trying to make tests work and noticed that including this header helps, got cheered up and wasn't looking further. But making tests work without including the header is even better of course.