Attention is currently required from: Anastasia Klimchuk. Hello build bot (Jenkins), Edward O'Callaghan, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/52595
to look at the new patch set (#2).
Change subject: mec1308.c: Extract params check into a function ......................................................................
mec1308.c: Extract params check into a function
This allows char *p to become a local variable in check_params, and it is allocated and freed within check_params function. Which means init function does not need char *p anymore, in particular does not need to free it - and this makes cleanup after failed init easier.
As a good side effect, init function becomes easier to read.
TEST=builds and ninja test from 51487 BUG=b:185191942
Change-Id: If5be7709e93233a2e7ea9133de50382d2524a55f Signed-off-by: Anastasia Klimchuk aklm@chromium.org --- M mec1308.c 1 file changed, 16 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/95/52595/2