Daniel Thompson has posted comments on this change. ( https://review.coreboot.org/27444 )
Change subject: usbdev: Refactor device discovery code
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/27444/2/usbdev.c
File usbdev.c:
https://review.coreboot.org/#/c/27444/2/usbdev.c@84
PS2, Line 84: void *
Ack
To follow up, the compiler won't let us do this. We no longer match the filter_func prototype if we change this... and other filters *do* need to alter the context pointer so we cannot change filter_t/filter_func.
--
To view, visit
https://review.coreboot.org/27444
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I31ed572501e4314b9455e1b70a5e934ec96408b1
Gerrit-Change-Number: 27444
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Thompson
daniel.thompson@linaro.org
Gerrit-Reviewer: Daniel Thompson
daniel.thompson@linaro.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 24 Aug 2018 15:38:26 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No