Attention is currently required from: Stefan Reinauer, Edward O'Callaghan, Angel Pons, Arthur Heymans.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52470 )
Change subject: hwaccess.c: Fix PowerPC memory barrier
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/52470/comment/919b1eca_51ba6857
PS1, Line 10: rotten link.
That seems extremely likely Angel, good spot! It is very unfortunate the toolchain defaults of a giv […]
If you know any alternative to papering over the deficiencies of all the
environments flashrom supports, I'd be happy to listen. Just stating that
the current practice isn't ideal doesn't fix anything.
For sparc we got one emulation target working: CB:52485.
The infrastructure to build test flashrom on many targets exists since
the 1.0 release. That you chose to ignore it over the last years is very
unfortunate.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/52470
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia84fd1362a1d39aca6269eef22ac994dee68ba4b
Gerrit-Change-Number: 52470
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 22 Apr 2021 15:27:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment