Attention is currently required from: Nico Huber, Thomas Heijligen.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59279 )
Change subject: pcidev: Move pci_card_find() from internal to canonical place
......................................................................
Patch Set 6:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/59279/comment/7e00812f_5c4b7f28
PS5, Line 10: sudo ./flashrom -p internal -r /tmp/bios
Yes, so my point was, TEST info does not mention what environment the command was performed. […]
It was done across multiple environments, I just gave that as a example.
Patchset:
PS5:
This patch also renames the function. This is not mentioned anywhere. […]
Re commit message not mentioning the rename, Fixed.
The patch chain is going beyond just reshuffling things. CB:55848 looks cosmetic only although it probably should have been merged promptly instead of sitting in gerrit forever. Sadly it is out of date now.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/59279
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I026bfbecba114411728d4ad1ed8969b469fa7d2d
Gerrit-Change-Number: 59279
Gerrit-PatchSet: 6
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Comment-Date: Fri, 18 Mar 2022 09:07:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment