Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/45438 )
Change subject: tests: Update licence headers
......................................................................
Patch Set 2: Code-Review+2
Patch Set 2: Code-Review+2
Patch Set 1: Code-Review+1
This would need a rebase now that CB:45431 has been merged.
I rebased this CL on top of master so that it passes the builder.
Also, it would be nice if we could have tests for the cache.
Agreed, please improve the test cov for the cache.
I think that's out of scope for this commit, though?
Yep, that's also fair to say.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/45438
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia964279ace569b4b93f4e2919c1c228a9b621745
Gerrit-Change-Number: 45438
Gerrit-PatchSet: 2
Gerrit-Owner: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 17 Sep 2020 00:47:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment