18 Nov
2020
18 Nov
'20
10:23 a.m.
Damien Zammit has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47661 )
Change subject: it87spi.c: Reorder functions with primitives at the top ......................................................................
Patch Set 1: Code-Review+1
This change looks good to me, a simple reordering that makes it unnecessary to have out-of-order prototypes for static functions.
--
To view, visit https://review.coreboot.org/c/flashrom/+/47661
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I94b169d19cb29336bb9cb4c16d0efee15b1e14c2
Gerrit-Change-Number: 47661
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Sam McNally sammc@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 18 Nov 2020 10:23:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment