Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41644 )
Change subject: tests/: Add spi.c unit tests ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/flashrom/+/41644/2/tests/spi.c File tests/spi.c:
https://review.coreboot.org/c/flashrom/+/41644/2/tests/spi.c@15 PS2, Line 15: 0xAA55
Magic number?
Just something unique yes.
https://review.coreboot.org/c/flashrom/+/41644/2/tests/spi.c@44 PS2, Line 44: programmer_init( : CONFIG_DEFAULT_PROGRAMMER, : strdup(CONFIG_DEFAULT_PROGRAMMER_ARGS)
Why not use a variable for this one as well?
I think these unit-tests are pretty incomplete and horrible so I would be prepared to rebase this all to the end of the series as there is a lot of state that needs to be mocked to properly test probe_flash()