18 Apr
2021
18 Apr
'21
6:56 p.m.
Attention is currently required from: Nico Huber. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52284 )
Change subject: linux_spi.c: Separate shutdown from failed init cleanup ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2: Thanks for comments! I have created another patch https://review.coreboot.org/c/flashrom/+/52492 to fix all of them (since this one is already merged and I can’t change it). I also “replied” to the comments in the new patch, if anymore changes needed I will do everything in 52492.
--
To view, visit https://review.coreboot.org/c/flashrom/+/52284
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1c8da2878cd0e85a1e43ba9b4b8e6f3d9f38ae5c
Gerrit-Change-Number: 52284
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Nikolai Artemiev nartemiev@google.com
Gerrit-CC: Sam McNally sammc@google.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Mon, 19 Apr 2021 01:56:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment