Nico Huber has posted comments on this change. ( https://review.coreboot.org/19615 )
Change subject: Add probe_dummy for chips that are not practical to probe
......................................................................
Patch Set 1:
(1 comment)
OTOH...
https://review.coreboot.org/#/c/19615/1/chipdrivers.h
File chipdrivers.h:
https://review.coreboot.org/#/c/19615/1/chipdrivers.h@31
PS1, Line 31: int probe_dummy(struct flashctx *flash);
probe_dummy() sounds like it's not doing anything useful...
maybe something like `probe_forced()` instead?
--
To view, visit
https://review.coreboot.org/19615
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: I327400e337d6ce600c4f0f165f328715f5b341e2
Gerrit-Change-Number: 19615
Gerrit-PatchSet: 1
Gerrit-Owner: Urja Rannikko
urjaman@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philippe Mathieu-Daudé
f4bug@amsat.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 22 Jun 2017 13:09:32 +0000
Gerrit-HasComments: Yes