Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk, Peter Marheine.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52830 )
Change subject: lspcon_i2c_spi: Extract I2C bus parameter handling
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File i2c_helper_linux.c:
https://review.coreboot.org/c/flashrom/+/52830/comment/3126eac7_579391b2
PS1, Line 80: * TODO: Move this function to a common place, it is not specific to I2C */
I guess this todo is fixed now in this commit?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/52830
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I006b311c88feea37fe4b217f769b21ca1505def9
Gerrit-Change-Number: 52830
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Sun, 02 May 2021 23:43:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment