Attention is currently required from: Thomas Heijligen, Angel Pons, qianfan, Nicholas Chin.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70573 )
Change subject: ch347_spi.c: Add initial support for the WCH CH347 ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
WCH has a greate tool for CH347 named CH347Demo and you can get it from https://www.wch. […]
Nicholas, Qianfan, thank you so much for your contribution! It doesn't happen often that we get a new programmer, and now you two are working on it - this is so cool! I really hope you will be able to rebase one patch on the top of the other, to get the best of both, and so that none of your work is lost.
I apologise that I haven't reviewed patches myself, and I won't be able until around mid-January. I will do that, unless of course the patches already merged to that time. Although, realistically, end of Dec - beginning Jan is a time when people might have less availability.
In any case: if we fast-forward to the time when patches are merged, I have a question for you both. Would you agree to add yourselves into flashrom's MAINTAINERS file for ch347_spi.c ? That would mean: if someone sends a patch modifying ch347_spi.c, you will be automatically added as reviewers. Also, MAINTAINERS serves as a piece of documentation, to find people "who knows something about X?". It would be really great if you agree!