10 May
2023
10 May
'23
6:19 a.m.
Attention is currently required from: Jason Glenesk, Martin Roth, Marshall Dawson, Paul Menzel, Anastasia Klimchuk, Felix Held.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65237 )
Change subject: sb600spi.c: Everything after rev 0x4a is a SPI100 ctrl ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Edward, thank you so much for working on this ! Can we revive this patch series and complete your wo […]
That sounds good. You can split everything post CHIPSET_PROMONTORY in this driver into the amd_spi100.c too so you end up with that and sb600spi.c
--
To view, visit https://review.coreboot.org/c/flashrom/+/65237
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id1c526e04ef4cf1f9a036328cbfb0d14ec310116
Gerrit-Change-Number: 65237
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk aklm@chromium.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 10 May 2023 04:19:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment