Attention is currently required from: Edward O'Callaghan.
Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47356 )
Change subject: tests/: Add programmer enumerate correspondence test
......................................................................
Patch Set 3:
(1 comment)
File tests/flashrom.c:
https://review.coreboot.org/c/flashrom/+/47356/comment/49c2b79a_631feaa9
PS3, Line 94: validate_prog_enumerates_test_success
I don't quite understand, here is the test whether the order in program_table meets the definition of prog_names?
The order of programmer enum may still be wrong, especially when doing "make CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_XXX"
--
To view, visit
https://review.coreboot.org/c/flashrom/+/47356
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I13efc4561f743edf51326d4b408be8715b630377
Gerrit-Change-Number: 47356
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: Shiyu Sun
sshiyu@google.com
Gerrit-Reviewer: Victor Ding
victording@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Xiang Wang
merle@hardenedlinux.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Mon, 18 Jan 2021 03:04:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment