30 Sep
2023
30 Sep
'23
8:40 a.m.
Attention is currently required from: Nikolai Artemiev, Stefan Reinauer, rogeryou.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/78142?usp=email )
Change subject: flashchips: Test MXIC MX25U25643G wp ......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2: Thank you for the patch! I have one comment, please see below.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/78142/comment/c1e4167c_14bd3b74 : PS2, Line 10308: STATUS2 Should this be CONFIG ? TB bit is defined in configuration register (Table 8). I hope I am not mistaken.
Commit message says you tested WP, could you maybe give a detailed list of WP commands that you tested?
--
To view, visit https://review.coreboot.org/c/flashrom/+/78142?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I43de9ed123b9736c04d070754bcf9c32be5697ad
Gerrit-Change-Number: 78142
Gerrit-PatchSet: 2
Gerrit-Owner: rogeryou
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: rogeryou
Gerrit-Attention: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Attention: Nikolai Artemiev nartemiev@google.com
Gerrit-Comment-Date: Sat, 30 Sep 2023 08:40:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment