Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47356 )
Change subject: tests/: Add programmer enumerate correspondence test
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/c/flashrom/+/47356/2/tests/flashrom.c
File tests/flashrom.c:
https://review.coreboot.org/c/flashrom/+/47356/2/tests/flashrom.c@96
PS2, Line 96: (void)
casts are unary operators, and shouldn't use a space
https://review.coreboot.org/c/flashrom/+/47356/2/tests/flashrom.c@99
PS2, Line 99: const char *prog_names
const char *const prog_names
--
To view, visit
https://review.coreboot.org/c/flashrom/+/47356
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I13efc4561f743edf51326d4b408be8715b630377
Gerrit-Change-Number: 47356
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: Shiyu Sun
sshiyu@google.com
Gerrit-Reviewer: Victor Ding
victording@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 09 Nov 2020 13:21:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment