Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk, Sergii Dmytruk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66211 )
Change subject: spi25_statusreg: support reading/writing "configuration registers"
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS2:
Even without the `CONFIGx` names, register to opcode mapping is not 1:1. […]
Rather and deep dive here and distract away from the scope of what the author of this commit is trying to archive. I think it would be prudent to splinter this off into the mailing list and unblock this patch in the follow way:
Since there is some discussion here on the merits of aliasing in this case could we please not blend that into this commit and instead introduce the alias in another commit - possibly with a design discussion on the mailing list Nico so we unblock this commit somehow depending on this debate.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/66211
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I45f9afcc31f1928ef6263a749596380082963de4
Gerrit-Change-Number: 66211
Gerrit-PatchSet: 7
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk
aklm@chromium.org
Gerrit-CC: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Tue, 08 Nov 2022 02:57:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-MessageType: comment