3 Jul
2019
3 Jul
'19
5:29 a.m.
Alan Green has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33931 )
Change subject: flashchips.c: Sort file by vendor and model ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/33931/3/flashchips.c File flashchips.c:
https://review.coreboot.org/#/c/33931/3/flashchips.c@29 PS3, Line 29: Within families keep them in order of density.
You're right. Thank you for pointing it out. I update the comment to match the new reality.
Done
--
To view, visit https://review.coreboot.org/c/flashrom/+/33931
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I75a99583592526f60ba5264e92391bf8b1213b20
Gerrit-Change-Number: 33931
Gerrit-PatchSet: 5
Gerrit-Owner: Alan Green avg@google.com
Gerrit-Reviewer: Alan Green avg@google.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 03 Jul 2019 05:29:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alan Green avg@google.com
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment