Attention is currently required from: Thomas Heijligen, David Hendricks, Edward O'Callaghan.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/31016 )
Change subject: hwaccess: add endianness converting deserialization functions
......................................................................
Patch Set 19:
(1 comment)
File platform/memaccess.c:
https://review.coreboot.org/c/flashrom/+/31016/comment/2f5d48d1_4daee6cb
PS19, Line 26: base + offset
can we just use uintptr_t as type instead of void*? […]
That would mean every caller who has a pointer (they usually have)
would have to do the cast. It's most likely less hassle to hide
the casting here. `void *` is particularly nice in the function
signature as you can call it with any pointer without a cast.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/31016
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Idde177acf8bc5f94cd046b6539dc31532c98e452
Gerrit-Change-Number: 31016
Gerrit-PatchSet: 19
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Tue, 12 Apr 2022 10:35:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Gerrit-MessageType: comment