Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44621 )
Change subject: allow 0x34 as ICCRIBA for CHIPSET_C620_SERIES_LEWISBURG
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/flashrom/+/44621/2/ich_descriptors.c
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/44621/2/ich_descriptors.c@a943
PS2, Line 943: return CHIPSET_300_SERIES_CANNON_POINT;
The default path for 0x34 (without warning) leads here. If you change that, […]
Unfortunately I have not found any documentation related to ICCRIBA.
On DeltaLake DVT server, ICCRIBA is 0x34. When it uses original default (CHIPSET_300_SERIES_CANNON_POINT), flashrom fails, not able to parse the descriptor. But when CHIPSET_C620_SERIES_LEWISBURG is chosen, it works well.
I wonder if any PCH of CHIPSET_300_SERIES_CANNON_POINT has ICCRIBA as 0x34.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/44621
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I363aaccfb90e0a127c0f0bb0072e9e85c210b669
Gerrit-Change-Number: 44621
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: David Hendricks
dhendrix.sync@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 20 Aug 2020 21:15:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment