Attention is currently required from: Thomas Heijligen, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61276 )
Change subject: hwaccess_x86_io: clean header concept
......................................................................
Patch Set 13: Code-Review+1
(3 comments)
Patchset:
PS13:
We should definitely build-test this...
File hwaccess_x86_io.c:
https://review.coreboot.org/c/flashrom/+/61276/comment/22bbe655_5d99edd2
PS13, Line 63: #define IO_PORT_PERMISSION USE_IOPL
That's new, isn't it?
https://review.coreboot.org/c/flashrom/+/61276/comment/796cb82b_d71d593c
PS13, Line 67: #if defined(__linux__) && !defined(__ANDROID__)
What happened to __GLIBC__?
One tricky case seems to be FreeBSD-glibc, with USE_DEV but `sys/io.h`.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/61276
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1400704e9ac5fed00c096796536108d5bfb875e3
Gerrit-Change-Number: 61276
Gerrit-PatchSet: 13
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Edward O'Callaghan
quasisec@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Peter Marheine
pmarheine@chromium.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 21 Feb 2022 22:33:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
