1 Jul
2021
1 Jul
'21
3:16 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33542 )
Change subject: layout: Introduce layout_next() ......................................................................
Patch Set 9:
(2 comments)
File layout.c:
https://review.coreboot.org/c/flashrom/+/33542/comment/adf2bba7_bb829641 PS9, Line 269: "%s [0x%08x-0x%08x] overlap\n", Seems like a useful message, why is it only debug?
https://review.coreboot.org/c/flashrom/+/33542/comment/9fceb2ef_a7f857c7 PS9, Line 280: if (rhs->included) Naughty typo!
I hope that's the only bug I've introduced in this series /o\
--
To view, visit https://review.coreboot.org/c/flashrom/+/33542
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I284958471c61344d29d92c95d88475065a9ca9aa
Gerrit-Change-Number: 33542
Gerrit-PatchSet: 9
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Daniel Campello campello@chromium.org
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Peter Marheine pmarheine@chromium.org
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Comment-Date: Thu, 01 Jul 2021 13:16:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment