Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/36420 )
Change subject: sb600spi.c: Consolidate smbus dev reversion derivation
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/flashrom/+/36420/3/sb600spi.c
File sb600spi.c:
https://review.coreboot.org/c/flashrom/+/36420/3/sb600spi.c@103
PS3, Line 103: if (rev < 0)
: return;
I think this is actually checking for the `if (!smbus_dev) {` branch taken and thus the returned -1 […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/36420
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I766b29cc1c7d01aa0bcf6cb9ff5ab73fa1995dcd
Gerrit-Change-Number: 36420
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 14 Nov 2019 12:14:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment