Attention is currently required from: Anastasia Klimchuk, Anton Samsonov, Thomas Heijligen.
Anton Samsonov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79152?usp=email )
Change subject: Makefile: Fix version string for non-Git builds
......................................................................
Patch Set 6:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/79152/comment/a8cacba5_0f9cb20b :
PS5, Line 7: non-Git builds
How do you get the repo without Git?
This patch applies to standalone source trees produced by GitHub snapshot (“Download ZIP” form of repo cloning), as well as `git archive`, and perhaps future releases.
In fact, meson.build already behaves as expected in both Git- and non-Git scenarios — I just mirrored this behavior to Makefile.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/79152?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I8694e618878823a9e96b1f2bcfa63f6c71d3c2ed
Gerrit-Change-Number: 79152
Gerrit-PatchSet: 6
Gerrit-Owner: Anton Samsonov
devel@zxlab.ru
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Anton Samsonov
avscomputing@gmail.com
Gerrit-CC: Anton Samsonov
contact-launchpad@zxlab.ru
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Anton Samsonov
devel@zxlab.ru
Gerrit-Comment-Date: Wed, 21 Feb 2024 17:57:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment