Attention is currently required from: Thomas Heijligen, Paul Menzel, Peter Marheine.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61194 )
Change subject: hwaccess: fix build on non-x86 targets
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS1:
I've now opted to put the x86 guards in the headers rather than in the files that include them because otherwise the guards would need to be duplicated across three other files.
These three other files happen to be almost completely wrapped in `#if x86`,
right? It's just the #include that needs to be guarded as well, I guess
(beside the one call to rget_io_perms()). Let's better change those files
that are already a #if mess and not those that we cleaned up only just.
Mid-term we should separate the source code further, i.e. have x86 code
only in files compiled for x86, then we won't need no more #if.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/61194
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I20f122679c30340b2c73afd7419e79644ddc3c4e
Gerrit-Change-Number: 61194
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk
aklm@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Fri, 21 Jan 2022 15:53:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Comment-In-Reply-To: Peter Marheine
pmarheine@chromium.org
Gerrit-MessageType: comment