4 Oct
2018
4 Oct
'18
1:51 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/28910 )
Change subject: flashchips: Add W25Q128.V..W ......................................................................
Patch Set 2:
(2 comments)
only some nits left
https://review.coreboot.org/#/c/28910/2/flashchips.h File flashchips.h:
https://review.coreboot.org/#/c/28910/2/flashchips.h@928 PS2, Line 928: #define WINBOND_NEX_W25Q128_V_M 0x7018 /* W25Q128JVSM */ comment should be indented with a tab
https://review.coreboot.org/#/c/28910/2/flashchips.c File flashchips.c:
https://review.coreboot.org/#/c/28910/2/flashchips.c@15671 PS2, Line 15671: .name = "W25Q128.V..M", Entries should be ordered alphabetically. So this would come after W25Q128.V I guess
--
To view, visit https://review.coreboot.org/28910
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38397a0c831407afa21cddca8485664576fce92c
Gerrit-Change-Number: 28910
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Thu, 04 Oct 2018 13:51:44 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No