Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33997 )
Change subject: flashchips.h: merge definitions from Chromium fork ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/33997/2/flashchips.h File flashchips.h:
https://review.coreboot.org/#/c/33997/2/flashchips.h@400 PS2, Line 400: GIGADEVICE_GD25LQ128CD Is there no user of this in flashchips.c?
https://review.coreboot.org/#/c/33997/2/flashchips.h@470 PS2, Line 470: #define INTEL_HWSEQ 0xFFFE /* dummy ID for hardware sequencing */ Here in upstream we don't have intel hwseq support so better to leave this out for now and ship it with the rest of the support once we extract it out and send it in for review.