Urja Rannikko has posted comments on this change. ( https://review.coreboot.org/17954 )
Change subject: Enable continuous SPI reads ......................................................................
Patch Set 3:
I want something like this in, but i think it could be improved, and I'm unsure as to whether we'd need a new function for this.
1. I dont know of a 3-byte addressing chip that would have issues with this, but eg, N25Q512A is limited to the 256Mb segment the read started in due to it being a multi-die chip (and my memory says i read of a multi-die chip with 128Mb segments, but couldnt find it now).
2. serprog already overrided the read function to something like this. But i guess that can be removed in later patch.
To address the point 1, i'd rather just make spi_read_chunked have the "page_size" set to min(flash->chip->total_size*1024,16*1024*1024).
This wouldnt hurt existing other users of spi_read_chunked, since they're already using it with their appropriate chunksize (linux_spi might benefit since it uses it with getpagesize()), and it would be a lot less code.