28 Mar
2022
28 Mar
'22
9:55 a.m.
Attention is currently required from: Felix Singer, Paul Menzel, Edward O'Callaghan, Angel Pons. Light has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62726 )
Change subject: serprog.c: Avoid calling memcpy with NULL pointer arguments ......................................................................
Patch Set 14:
(1 comment)
File serprog.c:
https://review.coreboot.org/c/flashrom/+/62726/comment/24d80284_3d424861 PS14, Line 288: m
`calloc(1, 1 + parmlen);` so that sp[1] is zeroed in the case of `(parmlen:=0, params:=NULL)`.
Does it help to calloc there?
--
To view, visit https://review.coreboot.org/c/flashrom/+/62726
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I850123237e328f9548ba7f77a01888be2cbc9e7b
Gerrit-Change-Number: 62726
Gerrit-PatchSet: 14
Gerrit-Owner: Light aarya.chaumal@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Singer felixsinger@posteo.net
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 28 Mar 2022 09:55:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Gerrit-MessageType: comment