Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33518 )
Change subject: layout: Introduce layout_next_included() ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/33518/1/layout.c File layout.c:
https://review.coreboot.org/#/c/33518/1/layout.c@246 PS1, Line 246: : for (i = 0; i < layout->num_entries; ++i) { : if (!layout->entries[i].included) : continue; : if (!iterator) : return &layout->entries[i]; : if (iterator == &layout->entries[i]) : iterator = NULL; : }
This will result in an endless while-loop that is calling this if there are duplicate entries in the […]
It's not comparing entries but their pointers. But this is really ugly code (maybe even too ugly for an interim solution) so I rewrote it.