Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44420 )
Change subject: Add support for Comet Lake-U/400-series PCH ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/flashrom/+/44420/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/44420/1//COMMIT_MSG@10 PS1, Line 10: to CHIPSET_300_SERIES_CANNON_POINT.
Will we need to differentiate between Cannon and Comet Point PCHs? I would treat them as the same th […]
isn't that what I'm doing?
https://review.coreboot.org/c/flashrom/+/44420/1/chipset_enable.c File chipset_enable.c:
https://review.coreboot.org/c/flashrom/+/44420/1/chipset_enable.c@2015 PS1, Line 2015: {0x8086, 0x0284, B_S, DEP, "Intel", "Comet Lake U Premium", enable_flash_pch400},
We might also want to add 0x8086, 0x0284 (Comet Lake)
I'm guessing you meant a different ID than the one I already added :)