8 Jun
2021
8 Jun
'21
2:28 p.m.
Attention is currently required from: Thomas Heijligen, Edward O'Callaghan. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55118 )
Change subject: print.c: use static string for internal programmer name ......................................................................
Patch Set 7: Code-Review+2
(1 comment)
File print.c:
https://review.coreboot.org/c/flashrom/+/55118/comment/9136be3a_5aab8513 PS3, Line 478: programmer_table[PROGRAMMER_INTERNAL]->name
The code is explicit for the internal programmer. And similar code uses also a static string. […]
Hmmm, right. I thought "If the original author took care to avoid reduncancy, ...", but this is really just a single case out of so many.
--
To view, visit https://review.coreboot.org/c/flashrom/+/55118
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If2cf95c71425efdd864457e213dd34b929fe8805
Gerrit-Change-Number: 55118
Gerrit-PatchSet: 7
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Edward O'Callaghan quasisec@chromium.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Xiang W wxjstz@126.com
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Tue, 08 Jun 2021 14:28:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Thomas Heijligen src@posteo.de
Gerrit-MessageType: comment