16 May
2023
16 May
'23
4:16 p.m.
Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk.
Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75270 )
Change subject: doc: Add build instructions for NI-845x on Windows ......................................................................
Patch Set 1:
(1 comment)
File doc/dev_guide/building_from_source.rst:
https://review.coreboot.org/c/flashrom/+/75270/comment/bdd6cf9e_488a4490 PS1, Line 92: for **32-bit**. Add ``-Dprogrammer=ni845x_spi`` to your meson configuration. I know that the Makefile build is planned to be deprecated, but would not be useful to add an example make command like make HAS_LIB_NI845X=yes CONFIG_NI845X=yes just to ease the building users.
--
To view, visit https://review.coreboot.org/c/flashrom/+/75270
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I97ad08632f35aa241b3d19d9ce7711146e3f1f4a
Gerrit-Change-Number: 75270
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Miklós Márton martonmiklosqdev@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Tue, 16 May 2023 16:16:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment