Attention is currently required from: Felix Singer, Thomas Heijligen, Anastasia Klimchuk.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68247 )
Change subject: util: add bash completion script ......................................................................
Patch Set 6:
(3 comments)
File Makefile:
https://review.coreboot.org/c/flashrom/+/68247/comment/61fc925a_f3ac7259 PS4, Line 33: bash-completion
no, because that's a somewhat standard path where the bash-completion tool expects the completion ex […]
Felix is right. You can read more in [the docs](https://github.com/scop/bash-completion#faq) :)
Take a look at `Q. Where should I install my own local completions?`
File meson.build:
https://review.coreboot.org/c/flashrom/+/68247/comment/cbc0fe1e_b7a12834 PS4, Line 611: share/bash-completion/completions
How can the directory be changed?
Do you want me to add an option for `bash-completion/completions`?
File util/flashrom.bash-completion:
https://review.coreboot.org/c/flashrom/+/68247/comment/a1c19236_d4e268a0 PS4, Line 36: atahpt
Maybe it's better to have this list vertically, same as the other one? It takes more lines, but then […]
I just copied the `meson_options.txt` style. Let's see what others think.